Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a blocklyTextBubble CSS class to the text bubble #8331 #8333

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Nirmalkumar6112
Copy link

The basics

The details

Resolves

Fixes #8331 Add a blocklyTextBubble CSS class to the text bubble

Proposed Changes

Added a call to dom.addClass that adds a blocklyTextBubble CSS class to the this.svgRoot

dom.addClass(this.svgRoot, 'blocklyTextBubble');

@Nirmalkumar6112 Nirmalkumar6112 requested a review from a team as a code owner July 12, 2024 07:41
@Nirmalkumar6112 Nirmalkumar6112 requested a review from gonfunko July 12, 2024 07:41
Copy link

google-cla bot commented Jul 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the PR: fix Fixes a bug label Jul 12, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@BeksOmega BeksOmega requested review from BeksOmega and removed request for gonfunko July 12, 2024 15:58
@BeksOmega BeksOmega assigned BeksOmega and unassigned gonfunko Jul 12, 2024
@BeksOmega
Copy link
Collaborator

BeksOmega commented Jul 12, 2024

Hello, it looks like there are a few commits in this PR that aren't yours. To clean this up, you can rebase your branch on top of the latest rc/v12.0.0 branch. This will remove any commits that were added to rc/v12.0.0 since you created your branch.

Here are the steps to do that:

  1. Fetch the latest changes from rc/v12.0.0:

    git fetch upstream rc/v12.0.0
  2. Checkout your branch:

    git checkout [your-branch-name]
  3. Start an interactive rebase:

    git rebase -i upstream/rc/v12.0.0
  4. In the editor that opens, identify the commits that aren't yours. These are likely the ones at the top of the list.

  5. Change the word pick to drop for each commit you want to remove.

  6. Save and close the editor.

  7. Force push your changes to your branch: Note that force pushing is a dangerous operation because it overwrites commit history, so if you dropped the wrong commits you could lose work.

    git push -f origin [your-branch-name]

Once you've done this, the PR should only contain your commits.

Let me know if you have any questions or run into any issues!

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as changes needed.

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the fix. Once this passes CI I'll get it merged.

@BeksOmega BeksOmega changed the title fix: Add a blocklyTextBubble CSS class to the text bubble #8331 feat: Add a blocklyTextBubble CSS class to the text bubble #8331 Jul 16, 2024
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: fix Fixes a bug labels Jul 16, 2024
@BeksOmega BeksOmega merged commit c553206 into google:rc/v12.0.0 Jul 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants