fix: improve prompting when deleting variables #8529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
This PR resolves several issues when deleting variables:
Proposed Changes
Blockly.Variables.deleteVariable()
now takes an optional third argument,triggeringBlock
, corresponding to the block that triggered the deletion, which is used to filter it out of the list of block references correctly when determining whether to prompt the user. Before, it simply assumed that if there was one reference that was the block that triggered the deletion, but deletion across the flyout/workspace boundary violated that assumption. For backwards compatibility, this arg is optional, and if not provided (legacy apps, or programmatic variable deletion) the old "warn if > 1 references" behavior is preserved.