fix: Take the flyout into account when positioning the workspace after a toolbox change. #8617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
changed the title
gonfunko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes gonfunko/scratch-blocks#199 and gonfunko/scratch-blocks#187
Proposed Changes
This PR updates the code that handles repositioning the workspace in response to a toolbox item size change. It seems to have been written taking into account the normal auto-closing flyouts, but in Scratch, where the flyout is visible by default, the workspace was positioned as if the flyout wasn't present. This caused the first block dropped on the workspace to shift by the width of the flyout, and also caused blocks to be mispositioned when restoring the state of the workspace.