fix: treat media files as binary while packaging them #8706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8705
Proposed Changes
Adds
encoding: false
option togulp.src()
inpackageMedia()
to treat files as binary.Reason for Changes
Without this the files are interpreted as UTF-8, which corrupts binaries like MP3s etc. This was a breaking change in gulp 5.0.0.
Test Coverage
Manually tested with: