Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Build with C11 on MSVC in the standalone Bazel build
We require MSVC 2019 now, which has a /std:c11 flag. Enable it to match the CMake build and remove a blocker for requiring C11 unconditionally. (This select branch is also used by clang-cl. I had meant to figure out the @bazel_tools business as part of this, but it turns out clang-cl works better with the MSVC flags than the GCC ones anyway. -Wall in clang-cl is like MSVC's /Wall and actually means all warnings. Ideally we'd still condition this on the compiler, in case anyone uses MinGW, but we can figure that out later.) Tested with bazelisk build :all and bazelisk build --compiler=clang-cl :all on Windows. Change-Id: I4559789a221071eef39f9d34929f0e9c5994119e Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/61127 Commit-Queue: Adam Langley <agl@google.com> Auto-Submit: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
- Loading branch information
28e4a1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change broke my build:
I am building with this config (in .bazelrc` file):
Any ideas how work around it?
28e4a1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vertexwahn Please see the README for a link to our bug tracker. Can you please file a bug with more information? Specifically, the rest of the build output, so we can see:
In particular,
/std:c11
should only have been passed to C files, while your/std:c++20
option was passed as--cxxopt
which should only have been passed to C++ files. It's strange that, somehow, both flags were passed to some file.28e4a1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://bugs.chromium.org/p/boringssl/issues/detail?id=623