This repository was archived by the owner on May 25, 2022. It is now read-only.
Fix serialization of null @nullable fields: omit them entirely. #24
+222
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return 'Value {' | ||
| 'anInt=${anInt.toString()}\n' | ||
| 'aString=${aString.toString()}\n' | ||
| 'anotherString=${anotherString.toString()}\n' |
There was a problem hiding this comment.
should this be
anotherString?.toString()
anotherString might be null right?
Contributor
Author
There was a problem hiding this comment.
null.toString() returns "null", so this is fine.
|
lgtm. Thanks |
davidmorgan
force-pushed
the
fix-null-serialization
branch
from
3a4681b to
781f2ef
Compare
Contributor
Author
|
Thanks, improved the test as suggested. Merging+publishing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #23
This change is