Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DH Key compute check modification for OOB Pairing #526

Merged
merged 7 commits into from
Aug 29, 2024
Merged

Conversation

Gopi-SB
Copy link
Contributor

@Gopi-SB Gopi-SB commented Aug 8, 2024

Code change

  • for DH Key compute , ra and rb values are based on shared OOB randomizer value
  • oob_data_flag should be 1 if remote device oob data present
    image
  • initial shared OOB randomizer value should not modified
    Please review the changes

bumble/smp.py Outdated Show resolved Hide resolved
@barbibulle
Copy link
Collaborator

barbibulle commented Aug 12, 2024

@Gopi-SB You'll need to fix the linter/formatter errors before we can merge this. In general, the best way to avoid these errors is to run invoke project.pre-commit before submitting/updating a PR, this will catch those errors locally.

@Gopi-SB
Copy link
Contributor Author

Gopi-SB commented Aug 27, 2024

@barbibulle if the PR is good . Can you please merge to main

@zxzxwu
Copy link
Collaborator

zxzxwu commented Aug 28, 2024

@barbibulle 如果公關好的話。你能合併到main嗎

Please fix the test failures.

@Gopi-SB
Copy link
Contributor Author

Gopi-SB commented Aug 29, 2024

@zxzxwu test failure are fixed

@zxzxwu zxzxwu merged commit 4394a36 into google:main Aug 29, 2024
57 checks passed
@Gopi-SB Gopi-SB deleted the oob branch August 29, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants