Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ASHA service implementation and examples #536

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

zxzxwu
Copy link
Collaborator

@zxzxwu zxzxwu commented Aug 20, 2024

  • Rename asha_service -> asha
  • Make most ASHA service parameters configurable
  • Rewrite ASHA sink examples with asha and decoder modules

@zxzxwu zxzxwu force-pushed the asha branch 2 times, most recently from 5c4dbad to 3778884 Compare August 20, 2024 08:21
@zxzxwu zxzxwu requested a review from yuyangh August 20, 2024 08:47
@SilverBzH
Copy link
Collaborator

Hi Josh,

From within Android, we had our own Asha service that lives within our Bumble experiemental folder:
https://cs.android.com/android/platform/superproject/main/+/main:packages/modules/Bluetooth/pandora/server/bumble_experimental/asha.py;l=1?q=asha.py&sq=

I was not aware of an ASHA within Bumble. What is the situation on it ?

bumble/profiles/asha.py Outdated Show resolved Hide resolved
@zxzxwu
Copy link
Collaborator Author

zxzxwu commented Aug 22, 2024

Hi Josh,

From within Android, we had our own Asha service that lives within our Bumble experiemental folder: https://cs.android.com/android/platform/superproject/main/+/main:packages/modules/Bluetooth/pandora/server/bumble_experimental/asha.py;l=1?q=asha.py&sq=

I was not aware of an ASHA within Bumble. What is the situation on it ?

As you mentioned, this module is somehow contributed but not used by AOSP, so currently they don't have relationship with each other. The only usage is decoder module, but there isn't logical change so you don't need to change any code in AOSP.

@zxzxwu zxzxwu requested review from SilverBzH and removed request for yuyangh August 23, 2024 13:55
@zxzxwu zxzxwu merged commit 54a6f3c into google:main Aug 23, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants