Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_csis_servers: Update usage and add docs entry #561

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

wpiet
Copy link
Contributor

@wpiet wpiet commented Sep 27, 2024

Amends the usage of the script and the example that show when executed incorrectly.
Adds basic information to the examples section of the documentation.

Amends the usage of the script and the example that show when executed incorrectly.
Adds basic information to the `examples` section of the documentation.
Corrects the typo in the section's description.
@wpiet
Copy link
Contributor Author

wpiet commented Sep 30, 2024

Hi,

I ran the invoke project.lint and it produced warnings about unused imports in the file I had changed. So I tried removing them, but after I force-pushed, the avatar check started failing.

Then, I run black and it amended the print function I had changed. Hopefully all checks pass now.

@zxzxwu
Copy link
Collaborator

zxzxwu commented Sep 30, 2024

Hi,

I ran the invoke project.lint and it produced warnings about unused imports in the file I had changed. So I tried removing them, but after I force-pushed, the avatar check started failing.

Then, I run black and it amended the print function I had changed. Hopefully all checks pass now.

Failure in Avatar should be an unrelated issue. I am asking Avatar folks to check now.

@zxzxwu zxzxwu closed this Oct 1, 2024
@zxzxwu zxzxwu reopened this Oct 1, 2024
@zxzxwu zxzxwu merged commit 566ca13 into google:main Oct 1, 2024
92 of 112 checks passed
@wpiet wpiet deleted the csis-usage branch October 2, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants