Improve Broadcast Scanning #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zxzxwu
commented
Nov 15, 2024
•
zxzxwu
commented
- APP: Allow scanning for broadcast without name (check annoucement instead)
- Add BAP dataclass serializer
- Allow nullable codec specific configuration fields
- Remove BAP CodecID (use HCI CodecID/Format instead, though the term is a little bit confusing)
zxzxwu
force-pushed
the
auracast_scan
branch
from
2f2e2ff to
d131640
Compare
|
I use 3.10 typing annotations - with |
barbibulle
approved these changes
Nov 15, 2024
apps/auracast.py
Outdated
|
|
||
| broadcast_name = ( | ||
| advertisement.data.get(bumble.core.AdvertisingData.BROADCAST_NAME) | ||
| or 'Unknown' |
There was a problem hiding this comment.
there's a (small) risk of conflict here. If a real broadcast service uses the name 'Unknown', we don't know the difference. Maybe the best would be to allow passing None for the broadcast_name parameter of self.on_new_broadcast?
There was a problem hiding this comment.
Done. Skip name when it's None here.
zxzxwu
force-pushed
the
auracast_scan
branch
from
d131640 to
c88b32a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.