Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximum encryption key size to PairingDelegate #604

Conversation

jmdietrich-gcx
Copy link
Contributor

So far the maxmium encryption key size has been hardcoded to 16 bytes in 'send_pairing_request_command()' and 'send_pairing_response_comman()'. By making this configurable via the PairingDelegate, one can test how devices respond to smaller encryption key sizes. Default remains 16 bytes.

So far the maxmium encryption key size has been hardcoded to 16 bytes in
'send_pairing_request_command()' and 'send_pairing_response_comman()'. By
making this configurable via the PairingDelegate, one can test how devices
respond to smaller encryption key sizes. Default remains 16 bytes.
@barbibulle
Copy link
Collaborator

The code looks fine. Can you run the formatter before we can merge it? (see the automated checks for details on the formatting errors)

@jmdietrich-gcx
Copy link
Contributor Author

jmdietrich-gcx commented Dec 2, 2024

Fixed the code formatting in a new commit. Should I squash the new commit?

(Is VS Code supposed to auto format on save using the devcontainer?)

@barbibulle
Copy link
Collaborator

Fixed the code formatting in a new commit. Should I squash the new commit?

(Is VS Code supposed to auto format on save using the devcontainer?)

No need to squash. For formatting, I haven't checked the settings in the devcontainer. We use black as the formatter. I usually have my VSCode settings do that automatically for me, but you can also run invoke project.format from the top level of the repo, what will invoke the formatter for you.

@barbibulle barbibulle merged commit 97fcfc2 into google:main Dec 3, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants