-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD "disable_specific_metrics" which can remove specific metric by name or regex #2774
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @Alexbyy. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code seems to be copied from kube-state-metrics but misses licence requirements (Apache 2 requires you to state when code from a project is used elsewhere and kube-state-metrics uses Apache 2).
I added some comments too.
Would you tell me How can I triger the pull-cadvisor-e2e check? It's always waiting for status to be reported |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bobbypage I consider this work to be complete. Can you review, please?
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small comments. Can you please also squash this PR? Thanks!
I think that's somehow related to #2818 which dropped github actions on 1.14. Not sure, why it's still showing up, but the important thing is the 1.15 / 1.16 variants. |
thanks for the updates. Can you please also send a followup PR to update the docs https://github.com/google/cadvisor/blob/master/docs/runtime_options.md with the new flag as well? Thanks! |
#2769
This param is a denyList which named "disable_specific_metrics". Comma-separated list of metrics not to be enabled.It can remove specific metric by name or regex.