Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mon_group support for resctrl. #2793

Merged
merged 53 commits into from
Sep 21, 2021
Merged

Add mon_group support for resctrl. #2793

merged 53 commits into from
Sep 21, 2021

Commits on Mar 15, 2021

  1. Add mon_group support for resctrl. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    0f93f1a View commit details
    Browse the repository at this point in the history

  2. Do not try to setup the root container. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    3452cf3 View commit details
    Browse the repository at this point in the history

  3. Update klog version to avoid errors from golangci-lint. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    18d297d View commit details
    Browse the repository at this point in the history

  4. Update klog version in cmd to avoid errors from golangci-lint. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    3feb264 View commit details
    Browse the repository at this point in the history

  5. Fix go.sum 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    7aaaff7 View commit details
    Browse the repository at this point in the history

  6. Check if container moved between control groups only if its running. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    58a2e01 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Get NUMA nodes from MachineInfo.Topology. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    5561bd9 View commit details
    Browse the repository at this point in the history

  2. Make code thread safe again. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    9a1e6cb View commit details
    Browse the repository at this point in the history

  3. Fix typo. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    873cc47 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Refactor resctrl collector setup. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    d07084c View commit details
    Browse the repository at this point in the history

  2. Refactor resctrl utilies. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    801e883 View commit details
    Browse the repository at this point in the history

  3. Better name vars. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    75fabd7 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Add missing python3 in Dockerfile. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    a1619a7 View commit details
    Browse the repository at this point in the history

  2. Add missing procps in Dockerfile. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    0f274e4 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. Merge branch 'master' of github.com:google/cadvisor into creatone/res… 

    …ctrl
    Paweł Szulik committed May 10, 2021
    Configuration menu
    Copy the full SHA
    73c71b6 View commit details
    Browse the repository at this point in the history

  2. Use const instead of magic value. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed May 10, 2021
    Configuration menu
    Copy the full SHA
    03f8571 View commit details
    Browse the repository at this point in the history

  3. Delete an unnecessary setting of c.running to false. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed May 10, 2021
    Configuration menu
    Copy the full SHA
    29e1e19 View commit details
    Browse the repository at this point in the history

  4. Do not wrap the error from cAdvisor. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed May 10, 2021
    Configuration menu
    Copy the full SHA
    fc3b8ce View commit details
    Browse the repository at this point in the history

  5. Use path in error message. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed May 10, 2021
    Configuration menu
    Copy the full SHA
    ecb0156 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. Avoid goroutine looping. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed May 11, 2021
    Configuration menu
    Copy the full SHA
    e1f5e9b View commit details
    Browse the repository at this point in the history

  2. Do not use fscommon package from runc/libcontainer. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed May 11, 2021
    Configuration menu
    Copy the full SHA
    3951953 View commit details
    Browse the repository at this point in the history

  3. Fix const ASCII names. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed May 11, 2021
    Configuration menu
    Copy the full SHA
    7d36305 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Use same operator in func. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed May 12, 2021
    Configuration menu
    Copy the full SHA
    ee42de2 View commit details
    Browse the repository at this point in the history

  2. Introduce const variables. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed May 12, 2021
    Configuration menu
    Copy the full SHA
    7c1eeb2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:google/cadvisor into creatone/res… 

    …ctrl
    Paweł Szulik committed May 12, 2021
    Configuration menu
    Copy the full SHA
    a1ce724 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Introduce vendor_id in MachineInfo. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    3ffe422 View commit details
    Browse the repository at this point in the history

  2. Extend files which should be omitted when searching control group. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    ab3ee30 View commit details
    Browse the repository at this point in the history

  3. Add info about possible bug when reading resctrl values on AMD. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    a986999 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Use empty struct map instead of boolean. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    88b6b7c View commit details
    Browse the repository at this point in the history

  2. Move reading file logic. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    8bf947a View commit details
    Browse the repository at this point in the history

  3. Use scanner to read tasks file. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    c54e007 View commit details
    Browse the repository at this point in the history

  4. Change the way of searching for the control group. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    dbb54d2 View commit details
    Browse the repository at this point in the history

  5. Add comments. Use const value. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    731606d View commit details
    Browse the repository at this point in the history

  6. Comment function. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    15be02e View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Fix typo. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    d24ece6 View commit details
    Browse the repository at this point in the history

  2. Refactor getAllProcessThreads. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    c9da6fb View commit details
    Browse the repository at this point in the history

  3. Refactor GetVendorID. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    8162197 View commit details
    Browse the repository at this point in the history

  4. Rename VendorID. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    9c675e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. Resctrl collector should be aware of existing mon groups. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    a76478c View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Optimization for finding control/monitoring group. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    852f755 View commit details
    Browse the repository at this point in the history

  2. Avoid having ugly errors. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    97987d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. Merge branch 'master' of github.com:google/cadvisor into creatone/res… 

    …ctrl
    Paweł Szulik committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    c675d56 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Use strings.HasPrefix(). 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    e7628e7 View commit details
    Browse the repository at this point in the history

  2. Add comments. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    1db6ca2 View commit details
    Browse the repository at this point in the history

  3. Rename variables. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    fa9b5db View commit details
    Browse the repository at this point in the history

  4. Fix test. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    b3f311b View commit details
    Browse the repository at this point in the history

  5. Use string map instead of int. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    bbde636 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Now there is no need to use procps in Dockerfile. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    ea39458 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:google/cadvisor into creatone/res… 

    …ctrl
    Paweł Szulik committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    0ec4da2 View commit details
    Browse the repository at this point in the history

  3. Update to go 1.17. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    b76ee15 View commit details
    Browse the repository at this point in the history

  4. Add information about possible race condition. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    8c734a0 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Add warning when docker_only is not set. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    fb4b9c8 View commit details
    Browse the repository at this point in the history

  2. Fix typo. 

    Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
    Paweł Szulik committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    00b42cf View commit details
    Browse the repository at this point in the history