-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump runc to v1.0.0-rc93 #2809
bump runc to v1.0.0-rc93 #2809
Conversation
Signed-off-by: Harshal Patil <harpatil@redhat.com>
Hi @harche. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @ehashman @bobbypage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM, we definitely want to update to runc rc93. Only question, in past @dims updated runc in sync with containerd. And containerd only updated to runc rc93 in containerd 1.5, but that's still in beta and not released yet. @dims do you have thoughts, do we need to wait and update containerd and runc together or is it ok to just update runc for now? |
@bobbypage updating containerd to rc93 has started ... containerd/containerd#5036 So we can go ahead here in cadvisor. +1 from me! |
Thanks @bobbypage. I was wondering when are we planning to cut the next release? |
bump runc to v1.0.0-rc93.
This version of runc brings in really needed fixes for some of the metrics.
Signed-off-by: Harshal Patil harpatil@redhat.com