Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache id for cache info. #2847

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Add cache id for cache info. #2847

merged 2 commits into from
Apr 21, 2021

Conversation

hustcat
Copy link
Contributor

@hustcat hustcat commented Apr 13, 2021

Add cache id for cache info.

@google-cla google-cla bot added the cla: yes label Apr 13, 2021
@k8s-ci-robot
Copy link
Collaborator

Hi @hustcat. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hustcat hustcat force-pushed the cache_id branch 2 times, most recently from d72f164 to 062f85c Compare April 13, 2021 04:00
@k8s-ci-robot
Copy link
Collaborator

@hustcat: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hustcat
Copy link
Contributor Author

hustcat commented Apr 14, 2021

@dashpole e2e test seems some problem?

@dashpole
Copy link
Collaborator

/ok-to-test

@hustcat
Copy link
Contributor Author

hustcat commented Apr 16, 2021

Can anyone review this?

@hustcat
Copy link
Contributor Author

hustcat commented Apr 19, 2021

@dashpole Can you review this PR?

@Creatone Creatone self-assigned this Apr 19, 2021
Creatone
Creatone requested changes Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@Creatone Creatone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hustcat Only small nit. Add Id field to cacheInfo inside TestGetCacheInfo() (utils/sysinfo/sysinfo_test.go:1317)

Creatone
Creatone approved these changes Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@Creatone Creatone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Creatone Creatone merged commit 73fc5bc into google:master Apr 21, 2021
@enzoyes enzoyes mentioned this pull request May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Creatone Creatone Creatone approved these changes

Assignees

@Creatone Creatone

Labels
cla: yes ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hustcat @k8s-ci-robot @dashpole @Creatone