-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs/runtime_options): Update disable_metrics
parameters
#2851
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @fhemberger. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! |
/ok-to-test |
docs/runtime_options.md
Outdated
@@ -125,8 +125,7 @@ cAdvisor stores the latest historical data in memory. How long of a history it s | |||
--application_metrics_count_limit=100: Max number of application metrics to store (per container) (default 100) | |||
--collector_cert="": Collector's certificate, exposed to endpoints for certificate based authentication. | |||
--collector_key="": Key for the collector's certificate | |||
--disable_metrics=tcp,advtcp,udp,sched,process,hugetlb: comma-separated list of metrics to be disabled. Options are 'disk', 'network', 'tcp', 'advtcp', 'udp', 'sched', 'process', 'hugetlb', 'cpuset'. Note: tcp and udp are disabled by default due to high CPU usage. (default tcp,advtcp,udp,sched,process,hugetlb,cpuset) | |||
--disable_specific_metrics="": Comma-separated list of metrics not to be enabled. This list comprises of exact metric names and/or regex patterns.It differs from the 'disable_metrics' in that 'disable_specific_metrics' filters specific metrics, while 'disable_metrics' filters a certain type of metrics.Besides, 'disable_specific_metrics' will only disable metrics being exported by Prometheus.(default "") | |||
--disable_metrics=process,tcp,udp,sched: comma-separated list of metrics to be disabled. Options are 'disk', 'network', 'tcp', 'udp', 'percpu', 'sched', 'process'. Note: tcp and udp are disabled by default due to high CPU usage. (default process,tcp,udp,sched) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List is incomplete. See:
ignoreMetrics
for default ignore listignoreWhitelist
for all possible values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the text from the out from the latest release:
docker run --rm -ti gcr.io/cadvisor/cadvisor:latest -version
cAdvisor version v0.38.6 (30515557)
❯ docker run --rm -ti gcr.io/cadvisor/cadvisor:latest --help
Usage of /usr/bin/cadvisor:
<snip>
-disable_metrics metrics
comma-separated list of metrics to be disabled. Options are 'accelerator',
'cpu_topology','disk', 'diskIO', 'memory_numa', 'network', 'tcp', 'udp', 'percpu',
'sched', 'process', 'hugetlb', 'referenced_memory', 'resctrl'.
(default referenced_memory,cpu_topology,resctrl,udp,advtcp,sched,hugetlb,
memory_numa,tcp,process)
<snip>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing cpuset
- as far as I can see it is available in 0.39.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added cpuset
from 0.3.9.
https://github.com/google/cadvisor/blob/release-v0.39/cmd/cadvisor.go#L146
iOS application is missing a button that one needs to click to run Github Actions for first time contributor. I had to get up from a sofa, leave my drink and go to a computer. Terrible user experience ;) |
Update
disable_metrics
parameters to latest version