Add '-enable_metrics' option to docs / examples #2911
Conversation
|
Hi @eero-t. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
Ping! This updates documentation for feature that went in over month ago... |
docs/runtime_options.md
Outdated
| @@ -125,7 +125,8 @@ cAdvisor stores the latest historical data in memory. How long of a history it s | |||
| --application_metrics_count_limit=100: Max number of application metrics to store (per container) (default 100) | |||
| --collector_cert="": Collector's certificate, exposed to endpoints for certificate based authentication. | |||
| --collector_key="": Key for the collector's certificate | |||
| --disable_metrics=referenced_memory,cpu_topology,resctrl,udp,advtcp,sched,hugetlb,memory_numa,tcp,process: comma-separated list of metrics to be disabled. Options are 'accelerator', 'cpu_topology','disk', 'diskIO', 'memory_numa', 'network', 'tcp', 'udp', 'percpu', 'sched', 'process', 'hugetlb', 'referenced_memory', 'resctrl', 'cpuset'. (default referenced_memory,cpu_topology,resctrl,udp,advtcp,sched,hugetlb,memory_numa,tcp,process) | |||
| --disable_metrics=<metrics>: comma-separated list of metrics to be disabled. Options are accelerator,advtcp,app,cpu,cpuLoad,cpu_topology,cpuset,disk,diskIO,hugetlb,memory,memory_numa,network,oom_event,percpu,perf_event,process,referenced_memory,resctrl,sched,tcp,udp. (default advtcp,cpu_topology,cpuset,hugetlb,memory_numa,process,referenced_memory,resctrl,sched,tcp,udp) | |||
There was a problem hiding this comment.
You cannot disable app or cpu.
There was a problem hiding this comment.
Thanks, it's fixed now. This was originally part of my PR for removing the whitelist, but I forgot to remove those after splitting doc changes to PR of its own. I'll add separate doc update commit to the other PR.
I fixed "cadvisor-args.yaml" similarly.
Btw. I amended the changes to original commit and rebased the changes on master. Would you in future prefer me to do fixes in separate commits for easier review (with no rebases, unless there's a conflict)?
Fixes also -disable_metrics 'process' metric name in running.md, and updates list of '-disable_metrics' option metrics. Metrics names are now listed in sorted order. Note: I've followed the existing documentation convention of giving cAdvisor option names with two dashes (--enable_metrics) although current cAdvisor uses only one dash (-enable_metrics).
eero-t
force-pushed
the
metrics-doc-updates
branch
from
7130788
to
0a6c876
Compare
Fixes also -disable_metrics 'process' metric name in running.md, and updates list of '-disable_metrics' option metrics.
Note: I've followed the existing documentation convention of giving cAdvisor option names with two dashes (--enable_metrics) although current cAdvisor uses only one dash (-enable_metrics).