-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubernetes/cri-api to cAdvisor #2938
Conversation
/cc @qiutongs |
1e6d57d
to
9b51ba9
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
9b51ba9
to
8b6007b
Compare
8b6007b
to
46dedf3
Compare
/retest |
Add script that will copy https://github.com/kubernetes/cri-api/ directly in cAdvisor tree.
This is used to avoid adding cri-api as go module. This is not possible due to
cri-api
being in k/k staging repo. Since cAdvisor is also vendored back into k/k this would result in circular dependency. Copying CRI proto definitions is workaround for this issue../build/check_cri_defs.sh
./build/update_cri_defs.sh
can update the CRI definitions