Update cadvisor daemonset doc to customize the image version #3003
Conversation
|
Hi @qiutongs. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
deploy/kubernetes/README.md
Outdated
|
|
||
| From the `cadvisor/deploy/kubernetes/base` directory, to update the image version([reference](https://github.com/kubernetes-sigs/kustomize/blob/master/examples/image.md)): | ||
| ``` | ||
| kustomize edit set image gcr.io/cadvisor/cadvisor:${VERSION} |
There was a problem hiding this comment.
Maybe it would be a better idea to run this command like:
cd deploy/kubernetes/base && kustomize edit set image gcr.io/cadvisor/cadvisor:${VERSION} && cd ../../..
instead of writing "From the cadvisor..."
There was a problem hiding this comment.
Sure. Sounds better
deploy/kubernetes/README.md
Outdated
| VERSION=v0.42.0 | ||
| ``` | ||
|
|
||
| From the `cadvisor/` directory, to update the image version([reference](https://github.com/kubernetes-sigs/kustomize/blob/master/examples/image.md)): |
There was a problem hiding this comment.
Now it looks better but I think that you don't need "From the cadvisor/ directory..." cause it's obvious that we're running commands from the repository directory.
Could you change also line 17?
|
/retest |
|
Thanks! |
Update cadvisor daemonset doc to customize the image version.