Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k/utils to v0.0.0-20211116205334-6203023598ed #3014

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

Dingshujie
Copy link
Contributor

@Dingshujie Dingshujie commented Nov 17, 2021

cadvisor has memory leak: cadvisor watch all cgroup director. when file or directory delete, inotify will recevie IN_DELETE event, when cadvisor recevie IN_DELETE, cadvisor will call inotify RemoveWatch to remove watch descriptor. When watch descriptor delete before function called, function will return EINVAL, may lead this path remain in watches and paths map, and also not delete path in containersWatched, finally lead to memory leak

update k/utils repo to fixs inotify memory leak.

fixs #100241

@google-cla google-cla bot added the cla: yes label Nov 17, 2021
@k8s-ci-robot
Copy link
Collaborator

Hi @Dingshujie. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Dingshujie Dingshujie changed the title update k/utils to v0.0.0-20211116205334-6203023598ed Bump k/utils to v0.0.0-20211116205334-6203023598ed Nov 24, 2021
@Dingshujie
Copy link
Contributor Author

@bobbypage can you review this PR?

@Dingshujie
Copy link
Contributor Author

/assign @bobbypage

@bobbypage
Copy link
Collaborator

This picks up fix kubernetes/utils#228

@bobbypage
Copy link
Collaborator

Thanks @Dingshujie, LGTM!

@bobbypage
Copy link
Collaborator

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants