vendor: bump runc to 1.1.0 #3048
Conversation
Brought to you by go get -d github.com/opencontainers/runc@latest go mod tidy cd cmd go get -d github.com/opencontainers/runc@latest go mod tidy Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
Hi @kolyshkin. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bobbypage can you cut a release once this PR lands, so I can do the same bump in kubernetes? |
|
@bobbypage PTAL 🙏🏻 |
|
/lgtm |
Usually we cut new cAdvisor release prior to k/k release, so I was planning on cutting next 0.44 release closer to when k8s 1.24 will be released. I think we should be able to update update runc in k/k without also updating cAdvisor tag or is that not the case? |
Due to API changes in runc, I think it is not possible. Currently, in kubernetes/kubernetes#107149 I have updated cadvisor to commit a3b5f4f, but an unreleased version does not look good in go.mod. |
To clarify -- attempting this will result in compilation errors. |
|
ah, thank you for clarification, it makes sense due to the changes you made in #3031 I will cut a new release then to unblock updating runc update in k/k. Thanks! |
Filed #3055 to remind / track this, thanks @bobbypage! |
This updates vendored runc/libcontainer to 1.1.0, and google/cadvisor to a version updated to runc 1.1.0 (google/cadvisor#3048). Changes in vendor are generated by (roughly): ./hack/pin-dependency.sh github.com/google/cadvisor v0.44.0 ./hack/pin-dependency.sh github.com/opencontainers/runc v1.1.0 ./hack/update-vendor.sh ./hack/lint-dependencies.sh # And follow all its recommendations. ./hack/update-vendor.sh ./hack/update-internal-modules.sh ./hack/lint-dependencies.sh # Re-check everything again. Co-Authored-By: Kir Kolyshkin <kolyshkin@gmail.com>
This updates vendored runc/libcontainer to 1.1.0, and google/cadvisor to a version updated to runc 1.1.0 (google/cadvisor#3048). Changes in vendor are generated by (roughly): ./hack/pin-dependency.sh github.com/google/cadvisor v0.44.0 ./hack/pin-dependency.sh github.com/opencontainers/runc v1.1.0 ./hack/update-vendor.sh ./hack/lint-dependencies.sh # And follow all its recommendations. ./hack/update-vendor.sh ./hack/update-internal-modules.sh ./hack/lint-dependencies.sh # Re-check everything again. Co-Authored-By: Kir Kolyshkin <kolyshkin@gmail.com> Kubernetes-commit: 07af1bab707c16c7fde936dca6579002405159ac
This updates vendored runc/libcontainer to 1.1.0, and google/cadvisor to a version updated to runc 1.1.0 (google/cadvisor#3048). Changes in vendor are generated by (roughly): ./hack/pin-dependency.sh github.com/google/cadvisor v0.44.0 ./hack/pin-dependency.sh github.com/opencontainers/runc v1.1.0 ./hack/update-vendor.sh ./hack/lint-dependencies.sh # And follow all its recommendations. ./hack/update-vendor.sh ./hack/update-internal-modules.sh ./hack/lint-dependencies.sh # Re-check everything again. Co-Authored-By: Kir Kolyshkin <kolyshkin@gmail.com>
Brought to you by