Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api/v2: document and consume count=-1 #3089

Merged
merged 1 commit into from
Apr 17, 2022
Merged

api/v2: document and consume count=-1 #3089

merged 1 commit into from
Apr 17, 2022

Conversation

stevekuznetsov
Copy link
Contributor

The underlying code already knows how to consume count=-1 when fetching
all data points. This patch allows the server to accept such a value
from the client and pass it through.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

cc @mrunalp

@stevekuznetsov
api/v2: document and consume count=-1
a9eb0d5 
The underlying code already knows how to consume count=-1 when fetching
all data points. This patch allows the server to accept such a value
from the client and pass it through.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@k8s-ci-robot
Copy link
Collaborator

Hi @stevekuznetsov. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov
Copy link
Contributor Author

Ah, this has Prow!

/cc @mrunalp
/assign @mrunalp

@dims
Copy link
Collaborator

dims commented Apr 11, 2022

/ok-to-test

dims
dims approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrunalp
Copy link
Collaborator

mrunalp commented Apr 12, 2022

Looks fine to me.
@bobbypage ptal.

@bobbypage
Copy link
Collaborator

LGTM

dims
dims approved these changes Apr 17, 2022
View reviewed changes
Copy link
Collaborator

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims dims merged commit 808d2f5 into google:master Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc left review comments

@dims dims dims approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stevekuznetsov @k8s-ci-robot @dims @mrunalp @bobbypage @ncdc