Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PSP from kustomize deploy #3196

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Conversation

bobbypage
Copy link
Collaborator

@bobbypage bobbypage commented Nov 5, 2022

Removing PSP and related config since it is deprecated in 1.25.0.

Users can add their own config if needed (the example deploy is just simple namespace, daemonset, and service account).

Signed-off-by: David Porter david@porter.me

Removing PSP and related config since it is deprecated in 1.25.0.

Users can add their config if needed.

Signed-off-by: David Porter <david@porter.me>
@bobbypage
Copy link
Collaborator Author

/assign @dims

@bobbypage
Copy link
Collaborator Author

bobbypage commented Nov 5, 2022

Test:

$ kind create cluster
Creating cluster "kind" ...
 ✓ Ensuring node image (kindest/node:v1.25.2) 🖼
 ✓ Preparing nodes 📦
 ✓ Writing configuration 📜
 ✓ Starting control-plane 🕹️
 ✓ Installing CNI 🔌
 ✓ Installing StorageClass 💾
Set kubectl context to "kind-kind"
You can now use your cluster with:

kubectl cluster-info --context kind-kind

Have a nice day! 👋


$ kubectl get nodes -o wide
NAME                 STATUS   ROLES           AGE   VERSION   INTERNAL-IP   EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION           CONTAINER-RUNTIME
kind-control-plane   Ready    control-plane   47s   v1.25.2   192.168.8.2   <none>        Ubuntu 22.04.1 LTS   5.18.16-1rodete4-amd64   containerd://1.6.8

$ kubectl kustomize deploy/kubernetes/base | kubectl apply -f -
namespace/cadvisor created
serviceaccount/cadvisor created
daemonset.apps/cadvisor created

$ kubectl get pods -A
NAMESPACE            NAME                                         READY   STATUS    RESTARTS   AGE
cadvisor             cadvisor-ghq7f                               1/1     Running   0          7s
kube-system          coredns-565d847f94-24jl2                     1/1     Running   0          49s
kube-system          coredns-565d847f94-2qvqs                     1/1     Running   0          49s
kube-system          etcd-kind-control-plane                      1/1     Running   0          63s
kube-system          kindnet-f9ddq                                1/1     Running   0          49s
kube-system          kube-apiserver-kind-control-plane            1/1     Running   0          62s
kube-system          kube-controller-manager-kind-control-plane   1/1     Running   0          61s
kube-system          kube-proxy-sftsb                             1/1     Running   0          49s
kube-system          kube-scheduler-kind-control-plane            1/1     Running   0          61s
local-path-storage   local-path-provisioner-684f458cdd-6vxh4      1/1     Running   0          49s

@bobbypage
Copy link
Collaborator Author

Fixes #3193

@Creatone
Copy link
Collaborator

Creatone commented Nov 7, 2022

LGTM

Test:

λ ~/Repositories/cadvisor/ 8cf5212f* k get nodes
NAME      STATUS   ROLES           AGE    VERSION
node200   Ready    control-plane   2d6h   v1.25.3
node202   Ready    <none>          2d6h   v1.25.3
λ ~/Repositories/cadvisor/ 8cf5212f* k get pods -n cadvisor
NAME             READY   STATUS    RESTARTS   AGE
cadvisor-b8594   1/1     Running   0          23m
cadvisor-xlfzg   1/1     Running   0          23m

@bobbypage bobbypage merged commit f725247 into google:master Nov 7, 2022
@bobbypage
Copy link
Collaborator Author

Thanks @Creatone for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants