Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nerdctl to ignoredDevices #3267

Merged
merged 1 commit into from
Mar 19, 2023
Merged

add nerdctl to ignoredDevices #3267

merged 1 commit into from
Mar 19, 2023

Conversation

Rouzip
Copy link
Contributor

@Rouzip Rouzip commented Mar 12, 2023

Fix #3266

@k8s-ci-robot
Copy link
Collaborator

Hi @Rouzip. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Collaborator

dims commented Mar 13, 2023

/test all

@iwankgb
Copy link
Collaborator

iwankgb commented Mar 13, 2023

/retest

@iwankgb
Copy link
Collaborator

iwankgb commented Mar 14, 2023

@dims I think it can be merged - such interfaces are indeed created and should be probably ignored.

Copy link
Collaborator

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@dims
Copy link
Collaborator

dims commented Mar 14, 2023

/hold

hmmm

@dims
Copy link
Collaborator

dims commented Mar 14, 2023

@Rouzip the strings are different, by design? or typo?

image

@Rouzip
Copy link
Contributor Author

Rouzip commented Mar 18, 2023

@Rouzip the strings are different, by design? or typo?

image

Sorry for the late reply, I used “nerdctl0” in the unit test, which is different from the code above. This is because nerdctl will create a virtual bridge like “nerdctlxxx”, similar to docker.
telegram-cloud-document-5-6100215378485446526

@JOJUNGCHEOL
Copy link

Rouzip:add-nerdctl

@JOJUNGCHEOL
Copy link

감사드립니다,☺️

@dims
Copy link
Collaborator

dims commented Mar 19, 2023

thanks @Rouzip !

@dims dims merged commit 2062bf5 into google:master Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ignored network Devices
5 participants