-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.46] Backport of PR 3301 to 0.46 #3320
Conversation
Hi @harche. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@rphillips: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM |
/retest |
@harche: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dims, is this something that Kubernetes needs? |
/ok-to-test |
@harche can you rebase this? I merged a few fixes to CI to get it green. |
Signed-off-by: Harshal Patil <harpatil@redhat.com> Co-authored-by: Ryan Phillips <rphillips@redhat.com>
Done. Thanks. |
/test pull-cadvisor-e2e |
/lgtm |
This PR backports the changes from #3301 to 0.46