Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.46] Backport of PR 3301 to 0.46 #3320

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

harche
Copy link
Contributor

@harche harche commented May 31, 2023

This PR backports the changes from #3301 to 0.46

@k8s-ci-robot
Copy link
Collaborator

Hi @harche. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harche
Copy link
Contributor Author

harche commented May 31, 2023

/cc @haircommander @bobbypage

@rphillips
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot
Copy link
Collaborator

@rphillips: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Contributor

LGTM

@harche
Copy link
Contributor Author

harche commented Jun 1, 2023

/retest

@k8s-ci-robot
Copy link
Collaborator

@harche: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iwankgb
Copy link
Collaborator

iwankgb commented Jun 8, 2023

@dims, is this something that Kubernetes needs?

@dims
Copy link
Collaborator

dims commented Jun 8, 2023

/ok-to-test

@bobbypage
Copy link
Collaborator

@harche can you rebase this? I merged a few fixes to CI to get it green.

Signed-off-by: Harshal Patil <harpatil@redhat.com>
Co-authored-by: Ryan Phillips <rphillips@redhat.com>
@harche
Copy link
Contributor Author

harche commented Jun 20, 2023

@harche can you rebase this? I merged a few fixes to CI to get it green.

Done. Thanks.

@harche
Copy link
Contributor Author

harche commented Jun 20, 2023

/test pull-cadvisor-e2e

@haircommander
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants