-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add misc controller metrics #3420
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @mythi. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me, except for the changes in runc usage, but I'll let others comment on that.
moving away from draft to get more feedback. |
any early feedback from the maintainers? |
/ok-to-test |
Can you undo changes to |
The PR won't build without those changes. I can rebase to resolve conflicts to get the e2e tests going but I believe we can wait with this PR until runc 1.2.0 comes out. |
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Modeled after Hugetlb support (except that this skips DeprecatedContainerStats) and added to sources after it.
Modeled after Hugetlb support and added to sources after it.
Modeled after Hugetlb support and added to sources after it.
@mythi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Keeping it draft still since it pulls
github.com/opencontainers/runc@main
.