Expose Podman version info #3552
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @riyad. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@riyad, you need to sign Google CLA. |
container/podman/podman.go
Outdated
| status.Version, _ = VersionString() | ||
| status.APIVersion, _ = APIVersionString() |
There was a problem hiding this comment.
Can you log these errors, please?
There was a problem hiding this comment.
I was ignoring them, because both fields are set to "Unknown" by docker.StatusFromDockerInfo() above.
Similarly both functions also return "Unknown" in case of an error.
I've pushed 31c860f with error handling to make this behavor more explicit.
Please have a look. 😃
|
/retest |
|
@riyad please rebase to current master |
riyad
force-pushed
the
add-podman-version-info
branch
from
143beab
to
4905144
Compare
This exposes the Podman version and it's Docker API version. The fields were there, but they were always showing "Unknown".
This is how it looks after the patch:
