Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uninterruptible metric load d #3555

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

j4ckstraw
Copy link

Currently container_cpu_load_average_10s only trace running tasks, we need uninterruptible metric to find out offline load too. Here I add a metric named load.d

see https://github.com/torvalds/linux/blob/master/kernel/cgroup/cgroup-v1.c#L724C1-L743C3

Copy link

google-cla bot commented Jun 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @j4ckstraw. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@j4ckstraw j4ckstraw force-pushed the add-load-d-metrics branch 2 times, most recently from 07289d1 to f7f9855 Compare June 26, 2024 06:56
@iwankgb
Copy link
Collaborator

iwankgb commented Jun 28, 2024

/ok-to-test

@iwankgb
Copy link
Collaborator

iwankgb commented Jul 6, 2024

@j4ckstraw you may need to merge master, I think.

j4ckstraw added 2 commits July 8, 2024 09:23
Signed-off-by: j4ckstraw <wljjackstraw@gmail.com>
Signed-off-by: j4ckstraw <wljjackstraw@gmail.com>
@j4ckstraw
Copy link
Author

@j4ckstraw you may need to merge master, I think.

done. thank you for your comment.

@iwankgb iwankgb merged commit f163691 into google:master Jul 8, 2024
14 checks passed
@j4ckstraw
Copy link
Author

thanks @wenjianhn for the idea of load.d

@j4ckstraw j4ckstraw deleted the add-load-d-metrics branch July 9, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants