This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreviewImpl.Callback.onSurfaceChanged()
assumes that the camera has been initialized and started properly. However, there is no check for this whenstartCaptureSession()
is called byonSurfaceChanged()
.In particular, on first launch after install, the OS permissions dialog appears, which prevents
startCaptureSession()
from starting normally (fromCamera2.start()
). This invalidates the original assumption. However,startCaptureSession()
is called anyways, which leads to the IllegalStateException due to the camera not being started properly.The fix is to guarantee that
startCaptureSession()
is not called prematurely until the camera has been properly started.This fixes issue #11