Updated output_buildfile_suffix default to BUILD.bazel
#205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 24, 2020
Closed
|
Based on this thread (bazelbuild/bazel#4517), It seems like this is preferred. As it does cause some churn on the output, as you noticed with the examples, I'd make sure there is some consensus on this. @damienmg, @acmcarther, or @smklein any objections? |
|
Yes BUILD.bazel should be the default for automatically generated file, its works better with IDEs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #189
I've run into many situations where the
BUILDfile has conflicted other things on case insensitive filesystems. This should help avoid these situations.