Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable rust_analyzer and VSCode integration. #444

Closed
wants to merge 32 commits into from
Closed

Enable rust_analyzer and VSCode integration. #444

wants to merge 32 commits into from

Conversation

sayrer
Copy link
Contributor

@sayrer sayrer commented Aug 29, 2021

This worked for me, but I think this should wait until bazelbuild/rules_rust#907 is done.

@sayrer sayrer requested a review from acmcarther as a code owner August 29, 2021 21:21
@sayrer sayrer mentioned this pull request Aug 29, 2021
Closed
@sayrer
Copy link
Contributor Author

sayrer commented Aug 29, 2021

It looks like the one test error is due to

Error: rust_repositories() got unexpected keyword argument: include_rustc_srcs

running on Bazel 4.0.0. While we wait for that rules_rust patch to land, I think we could probably bump the versions here.

sayrer and others added 17 commits August 29, 2021 15:12
@sayrer
Update rules_rust version.
bdc2d59
@sayrer
Correct static lib order.
bc5b0f4
@acmcarther
Delete .travis.yml (google#445)
4cbe527 
This repo was migrated to buildkite ages ago, and Travis hasn't been functional for some time.
Up to 0.13.0 [via publish-new-version.sh]
a28427d
@djmarcin
Update rules_rust and rules_foreign_cc to latest
4703d08
@djmarcin
buildifier
26c99a4
@djmarcin
pcre is no longer served from ftp.pcre.org
63d5609
@UebelAndre
Merge pull request google#452 from djmarcin/main
0bc9b00 
Update rules_rust and rules_foreign_cc to latest
@vmax
Fix a small typo in the README (google#456)
e34a8a3
Fix clippy errors (google#457)
e123041
Update publish script to be more robust and take remote name (google#459
c7643ef 
)
Up to 0.13.1 [via publish-new-version.sh]
8b5b173
@vmax
Preserve original crate name as a Bazel target tag (google#455)
b90d70e
Up to 0.14.0 [via publish-new-version.sh]
d98f017
@PiotrSikora
Include "additional_flags" in build scripts. (google#461)
527f494 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
Sort "tags" (google#462)
b717769 
While there, regenerate examples and third_party.

Missed in google#455.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Up to 0.14.1 [via publish-new-version.sh]
41db1a7
@dfreese
Copy link
Collaborator

dfreese commented Jan 5, 2022

Would this be good to go now that bazelbuild/rules_rust#1010 is merged?

@sayrer sayrer closed this Mar 22, 2022
@sayrer sayrer deleted the rust_analyzer branch March 22, 2022 19:30
@sayrer sayrer restored the rust_analyzer branch March 22, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acmcarther acmcarther Awaiting requested review from acmcarther acmcarther is a code owner

@dfreese dfreese Awaiting requested review from dfreese

@UebelAndre UebelAndre Awaiting requested review from UebelAndre

@illicitonion illicitonion Awaiting requested review from illicitonion illicitonion is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sayrer @dfreese @acmcarther @djmarcin @UebelAndre @vmax @PiotrSikora @lehrbaumm @kevinji