[fuchsia] Updates the FIDL bindings in Fuchsia-specific code #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derekmauro @dinord are y'all able to review and merge this PR? |
dinord
reviewed
Nov 12, 2024
filmil
force-pushed
the
update-fuchsia-code
branch
from
7e80294 to
f4b9d80
Compare
Fuchsia has a code snippet that uses its FIDL IPC mechanism to request time zone information from the host. The generated FIDL bindings have been changed since this code was first written from the "high level" (HL) CPP bindings to the "new" CPP bindings. We are now migrating external code to remove the HL CPP bindings to allow FIDL to continue development. No other platforms should be affected, since the changes are in the sections of the code that is conditionally compiled only when Fuchsia is the target platform.
filmil
force-pushed
the
update-fuchsia-code
branch
from
f4b9d80 to
6e3a6d1
Compare
dinord
approved these changes
Nov 12, 2024
|
@dinord please merge when able - I am not allowed to. |
filmil
added a commit
to filmil/cctz
that referenced
this pull request
Nov 19, 2024
…oogle#302)" This reverts commit b98efcf. The reverted change introduced a 64KB stack allocation which overflowed stacks of some downstream programs.
dinord
pushed a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuchsia has a code snippet that uses its FIDL IPC mechanism to request time zone information from the host.
The generated FIDL bindings have been changed since this code was first written from the "high level" (HL) CPP bindings to the "new" CPP bindings.
We are now migrating external code to remove the HL CPP bindings to allow FIDL to continue development. No other platforms should be affected, since the changes are in the sections of the code that is conditionally compiled only when Fuchsia is the target platform.