-
Notifications
You must be signed in to change notification settings - Fork 227
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Numeric in/equality and comparisons across numeric types (#473)
* Numeric in/equality runtime changes to support comparisons of numbers across types * Fix for nan check
- Loading branch information
1 parent
94e74ac
commit fa20ec8
Showing
10 changed files
with
633 additions
and
105 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
// Copyright 2021 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package types | ||
|
||
import ( | ||
"math" | ||
) | ||
|
||
func compareDoubleInt(d Double, i Int) Int { | ||
if d < math.MinInt64 { | ||
return IntNegOne | ||
} | ||
if d > math.MaxInt64 { | ||
return IntOne | ||
} | ||
return compareDouble(d, Double(i)) | ||
} | ||
|
||
func compareIntDouble(i Int, d Double) Int { | ||
return -compareDoubleInt(d, i) | ||
} | ||
|
||
func compareDoubleUint(d Double, u Uint) Int { | ||
if d < 0 { | ||
return IntNegOne | ||
} | ||
if d > math.MaxUint64 { | ||
return IntOne | ||
} | ||
return compareDouble(d, Double(u)) | ||
} | ||
|
||
func compareUintDouble(u Uint, d Double) Int { | ||
return -compareDoubleUint(d, u) | ||
} | ||
|
||
func compareIntUint(i Int, u Uint) Int { | ||
if i < 0 || u > math.MaxInt64 { | ||
return IntNegOne | ||
} | ||
cmp := i - Int(u) | ||
if cmp < 0 { | ||
return IntNegOne | ||
} | ||
if cmp > 0 { | ||
return IntOne | ||
} | ||
return IntZero | ||
} | ||
|
||
func compareUintInt(u Uint, i Int) Int { | ||
return -compareIntUint(i, u) | ||
} | ||
|
||
func compareDouble(a, b Double) Int { | ||
if a < b { | ||
return IntNegOne | ||
} | ||
if a > b { | ||
return IntOne | ||
} | ||
return IntZero | ||
} | ||
|
||
func compareInt(a, b Int) Int { | ||
if a < b { | ||
return IntNegOne | ||
} | ||
if a > b { | ||
return IntOne | ||
} | ||
return IntZero | ||
} | ||
|
||
func compareUint(a, b Uint) Int { | ||
if a < b { | ||
return IntNegOne | ||
} | ||
if a > b { | ||
return IntOne | ||
} | ||
return IntZero | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.