Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string reverse member overload name #1045

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

TristonianJones
Copy link
Collaborator

@TristonianJones TristonianJones commented Oct 21, 2024

Update the string reverse() overload id to be unique to the type.

In the future overload IDs for a given function should not be equal to
the function name as this can interfere with dynamic dispatch for a
parsed-only expression.

This change should be a no-op for anyone using reverse today as
the behavior will effectively cause existing expressions to use the
dynamic dispatch rather than the specific overload once more overloads
are introduced under the reverse function.

@TristonianJones TristonianJones merged commit 1468aa0 into google:master Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants