Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Expr from NavigableExpr with interpreter support #788

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

TristonianJones
Copy link
Collaborator

@TristonianJones TristonianJones commented Aug 5, 2023

Introduce a Go-native Expr representation

This PR splits the Expr interface from the NavigableExpr interface and introduces
support for the native value within the interpreter call paths.

The following changes will be occur in the following sequence once this PR is submitted:

  • Update the type-checker to use the Expr value.
  • Update the parser / unparser / pruner to use the Expr value.
  • Introduce new Macro-related helpers to assist with backwards compatibility support
    for existing custom macros.

#789

checker/checker.go Outdated Show resolved Hide resolved
jcking
jcking previously approved these changes Aug 9, 2023
@TristonianJones TristonianJones merged commit a6388a3 into google:master Aug 9, 2023
2 checks passed
@TristonianJones TristonianJones deleted the expr-split branch August 9, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants