Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String formatting panic fix #987

Merged
merged 1 commit into from
Jul 30, 2024
Merged

String formatting panic fix #987

merged 1 commit into from
Jul 30, 2024

Conversation

TristonianJones
Copy link
Collaborator

String formatting panic fix

If the string format is not a literal, the formatting validation will panic
as it incorrectly used an && rather than an || on the validation
condition.

@TristonianJones TristonianJones requested a review from l46kok July 30, 2024 06:09
@TristonianJones TristonianJones mentioned this pull request Jul 30, 2024
Merged
@TristonianJones TristonianJones merged commit badfce0 into google:master Jul 30, 2024
2 checks passed
@TristonianJones TristonianJones deleted the string-format-fix branch July 30, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l46kok l46kok l46kok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TristonianJones @l46kok