Add support for WASI port #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix building when the new `wasip1` port is being used. This is a new target that will be introduced by go 1.21. For more details golang/go#58141 Signed-off-by: Flavio Castelli <fcastelli@suse.com>
mhutchinson
approved these changes
Jun 1, 2023
breadyzhang
pushed a commit
to breadyzhang/certificate-transparency-go
that referenced
this pull request
Jun 2, 2023
Fix building when the new `wasip1` port is being used. This is a new target that will be introduced by go 1.21. For more details golang/go#58141 Signed-off-by: Flavio Castelli <fcastelli@suse.com>
breadyzhang
pushed a commit
to breadyzhang/certificate-transparency-go
that referenced
this pull request
Jun 2, 2023
Fix building when the new `wasip1` port is being used. This is a new target that will be introduced by go 1.21. For more details golang/go#58141 Signed-off-by: Flavio Castelli <fcastelli@suse.com>
breadyzhang
pushed a commit
to breadyzhang/certificate-transparency-go
that referenced
this pull request
Jun 2, 2023
Fix building when the new `wasip1` port is being used. This is a new target that will be introduced by go 1.21. For more details golang/go#58141 Signed-off-by: Flavio Castelli <fcastelli@suse.com>
breadyzhang
pushed a commit
to breadyzhang/certificate-transparency-go
that referenced
this pull request
Jun 2, 2023
Fix building when the new `wasip1` port is being used. This is a new target that will be introduced by go 1.21. For more details golang/go#58141 Signed-off-by: Flavio Castelli <fcastelli@suse.com>
breadyzhang
pushed a commit
to breadyzhang/certificate-transparency-go
that referenced
this pull request
Jun 2, 2023
Fix building when the new `wasip1` port is being used. This is a new target that will be introduced by go 1.21. For more details golang/go#58141 Signed-off-by: Flavio Castelli <fcastelli@suse.com>
phbnf
pushed a commit
that referenced
this pull request
Jun 23, 2023
* Create additional conditions to determine log results and if a log should be submitted when minInclusions > 0. * modify chromeLike unit test to better fit the actual use case and refine how safeSubmissionState decides which SCTs to insert in the results * update changelog * Remove MaxSubmissions and set maxSubmissionsPerGroup from the minGroups value * Set max submissions per operator in ctpolicy package * Removed to reduce complexity and confusion. * Resolving comments - move base into switch expression - change maxSubmissionsPerGroup to maxSubmissionsPerOperator * Use MinDistinctOperators instead of MaxSubmissionsPerOperator to reduce confusion * Add zOS build support (#1088) * Add support for WASI port (#1089) Fix building when the new `wasip1` port is being used. This is a new target that will be introduced by go 1.21. For more details golang/go#58141 Signed-off-by: Flavio Castelli <fcastelli@suse.com> * update changelog * fix changelog merge issues * My merge conflict mishap reverted the change to have groups be a map[string]int so I am reverting it back to the updated state * replace groupNeeds with minSubmissions and change the name of groups to groupsSubmitted groupNeeds was used for the old chrome policy when we required SCTs from specific groups. It's not necessary anymore with the new policies so a single integer (minSubmissions) should be suffice. groups is changed to groupsSubmitted to make it easier to understand upon a glance. * change minSubmissions since it gets changed after initialization * Change dayDuration to use time.Hour for easier understanding * Resolve comments * add comments to clarify reservedSubmissions --------- Co-authored-by: Freddy Zhang <zhangfreddy@google.com> Co-authored-by: onlywork1984 <102848417+onlywork1984@users.noreply.github.com> Co-authored-by: Flavio Castelli <flavio@castelli.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix building when the new
wasip1port is being used.This is a new target that will be introduced by go 1.21.
For more details golang/go#58141
Checklist