Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow root checking to be optionally handled #1258

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

aaomidi
Copy link
Contributor

@aaomidi aaomidi commented Dec 2, 2023

Checklist

@aaomidi
Copy link
Contributor Author

aaomidi commented Feb 22, 2024

I have updated the CHANGELOG.

Adjust the draft version number according to semantic versioning rules.

Leaving this up to maintainers, seems like not a thing for me to do in a PR.

Let me know what docs update you may want for this.

@aaomidi aaomidi marked this pull request as ready for review February 22, 2024 06:40
@aaomidi aaomidi requested a review from a team as a code owner February 22, 2024 06:40
@aaomidi aaomidi requested review from phbnf and removed request for a team February 22, 2024 06:40
submission/distributor.go Outdated Show resolved Hide resolved
@phbnf
Copy link
Contributor

phbnf commented Mar 12, 2024

Thanks for the PR! Is this meant to be enabled at the server level with a flag?
Also, for CHANGELOG, you can simply add a line to CHANGELOG.md to mention that you've added a feature. Makes sense to me to ignore the rest of the message.

@phbnf
Copy link
Contributor

phbnf commented Mar 13, 2024

/gcbrun

@aaomidi
Copy link
Contributor Author

aaomidi commented Mar 13, 2024

Some context for history: This PR is a workaround for #1255.

Solving #1255 is going to require some careful work to ensure that we don't break any existing users. This option is intended to be used by folks who are doing the root checking on the log list level before supplying it to this codebase through the distributor.

@phbnf phbnf merged commit 8bd7bab into google:master Mar 13, 2024
6 checks passed
@aaomidi aaomidi deleted the roots_optional branch March 13, 2024 19:12
@aaomidi
Copy link
Contributor Author

aaomidi commented Mar 13, 2024

Thank you!

Copy link
Contributor

@roger2hk roger2hk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm late to the party but I've left some comments to follow up.

submission/distributor.go Show resolved Hide resolved
submission/distributor.go Show resolved Hide resolved
submission/proxy.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants