Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issuance chain cache interface #1431

Merged

Conversation

roger2hk
Copy link
Contributor

The non-leaf certificate chain cache interface contributes to #691.

Checklist

@roger2hk roger2hk marked this pull request as ready for review April 15, 2024 16:12
@roger2hk roger2hk requested a review from a team as a code owner April 15, 2024 16:12
trillian/ctfe/cache/cache.go Outdated Show resolved Hide resolved
@roger2hk roger2hk force-pushed the extra-data-cert-chain-cache-interface branch from 2a506a4 to a3df2b1 Compare April 16, 2024 21:49
Copy link
Contributor

@mhutchinson mhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small PRs like this are great, thanks! Happy to discuss any of these comments over chat if you disagree or want more context.

trillian/ctfe/cache/cache.go Show resolved Hide resolved
trillian/ctfe/cache/cache.go Outdated Show resolved Hide resolved
trillian/ctfe/cache/cache.go Outdated Show resolved Hide resolved
trillian/ctfe/cache/cache.go Outdated Show resolved Hide resolved
@roger2hk roger2hk changed the title Add non-leaf certificate chain cache interface Add issuance chain cache interface Apr 23, 2024
@roger2hk roger2hk requested review from mhutchinson and phbnf April 29, 2024 14:25
@roger2hk roger2hk merged commit f7baec8 into google:master Apr 29, 2024
6 checks passed
@roger2hk roger2hk deleted the extra-data-cert-chain-cache-interface branch April 29, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants