Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor issuance chain service #1512

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

mhutchinson
Copy link
Contributor

Primary goal is to have 2 separate implementations of the different services, instead of having both implementations inside the same class with conditional switching. This is realized by introducing a direct chain service that performs the legacy implementation of storing chains directly inside the extra data in Trillian. The logic for the new feature is now in an indirect chain service that requires the storage and cache that chains are stored in.

Primary goal is to have 2 separate implementations of the different services, instead of having both implementations inside the same class with conditional switching. This is realized by introducing a _direct_ chain service that performs the legacy implementation of storing chains directly inside the extra data in Trillian. The logic for the new feature is now in an _indirect_ chain service that requires the storage and cache that chains are stored in.
@mhutchinson mhutchinson requested a review from a team as a code owner June 10, 2024 10:07
@mhutchinson mhutchinson requested review from phbnf and removed request for a team June 10, 2024 10:07
@mhutchinson mhutchinson requested a review from roger2hk June 10, 2024 10:07
@phbnf
Copy link
Contributor

phbnf commented Jun 13, 2024

I'm OOO from tomorrow and next week, I'll have a look when I'm back.

Copy link
Contributor

@roger2hk roger2hk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Martin. The issuance chain service and the log leaf builder are now structured in a better way.

@mhutchinson mhutchinson merged commit a2d98c5 into google:master Jun 25, 2024
6 checks passed
@mhutchinson mhutchinson deleted the chainServiceRefactor branch June 25, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants