Add Trillian TLS support for ct_server #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
|
@fghanmi Do you have any use case to support TLS in migrillian? If so, we can consider keeping the TLS support there. |
Gotcha. This PR looks good to me to remove it from migrillian if there is no such a use case at the moment. |
roger2hk
reviewed
Aug 8, 2024
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
roger2hk
approved these changes
Aug 8, 2024
fghanmi
added a commit
to securesign/certificate-transparency-go
that referenced
this pull request
Aug 12, 2024
* Add Trillian TLS support for ct_server Signed-off-by: Firas Ghanmi <fghanmi@redhat.com> * update CHANGELOG.md Signed-off-by: Firas Ghanmi <fghanmi@redhat.com> * update trillianTLSCACertFile variable name Signed-off-by: Firas Ghanmi <fghanmi@redhat.com> --------- Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
fghanmi
added a commit
to securesign/certificate-transparency-go
that referenced
this pull request
Aug 12, 2024
Add Trillian TLS support for ct_server (google#1551)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Trillian TLS support for ct_server:
In a previous PR: #1525, this change was intended but was done on the wrong file
trillian/migrillian/main.goinstead oftrillian/ctfe/ct_server/main.goThis issue was identified while testing a real scenario. It should be fixed by this PR.
related isssue: #1524
Checklist