Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added backoff to fetcher worker to partially address #746 #747

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

mhutchinson
Copy link
Contributor

This is a huge improvement from retying without any backoff. However, this could still benefit from:

  • being tunable
  • supporting hard failing if requests can't be completed within the backoff configuration
  • resetting the backoff if requests start succeeding faster

This is a huge improvement from retying without any backoff. However, this could still benefit from being tuneable, supporting hard failing if requests can't be completed within the backoff configuration, and resetting the backoff if requests start succeeding faster.
@mhutchinson mhutchinson requested a review from pav-kv December 14, 2020 11:02
@google-cla google-cla bot added the cla: yes label Dec 14, 2020
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #747 (4be0e96) into master (7710282) will increase coverage by 0.05%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
+ Coverage   72.72%   72.78%   +0.05%     
==========================================
  Files          81       81              
  Lines        7887     7893       +6     
==========================================
+ Hits         5736     5745       +9     
+ Misses       1717     1715       -2     
+ Partials      434      433       -1     
Impacted Files Coverage Δ
scanner/fetcher.go 60.18% <90.90%> (+5.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7710282...4be0e96. Read the comment docs.

@mhutchinson
Copy link
Contributor Author

Latest commit addresses "resetting the backoff if requests start succeeding faster" from the initial description. This is still incrementally much better (and with no downsides compared to the original?), but not ideal.

scanner/fetcher.go Outdated Show resolved Hide resolved
scanner/fetcher.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants