-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctclient: Use Cobra library for command-line tools #901
Conversation
I recommend reviewing commit-by-commit. For now this is a structural change, with no behaviour changes (except the look of help hints). Next steps will be refactoring each command, and improving usability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nits - LVGTM in the grand scheme of things, thanks for doing this!
TODO in this PR:
|
This is an intermediate commit, only to demonstrate that the command implementations are preserved in this pull request. Having a separate cmd package is how integration with Cobra library usually works. Subsequent commits include Cobra.
Ping |
1 similar comment
Ping |
This change refactors the
ctclient
tool to use the widely adopted Cobra libraryfor handling CLI flags and subcommands.
Before:
After:
Part of #900
Checklist