Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use the loglist v3 schema everywhere #925

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

aarongable
Copy link
Contributor

The loglist3 package appears complete and is in use in a few places
throughout the repository. However, most of the repo still relies on the
loglist2 package. Although Chrome is still publishing log lists in both
formats, it seems appropriate to update the preponderance of usage to
the new schema.

This also adds a v3-formatted testdata file, with the same contents as
the corresponding v2 file. (This file will need to be updated when the
//ctpolicy/chromepolicy.go logic is updated, as it does not contain enough
different operator groups to truly exercise the new Chrome policy, but
that is an issue for #906).

Checklist

  • I have updated the CHANGELOG.
    • It doesn't seem to be necessary for a change this internal?
  • I have updated documentation accordingly.

@mhutchinson mhutchinson requested review from pav-kv and phbnf May 10, 2022 12:40
@pav-kv
Copy link
Contributor

pav-kv commented May 17, 2022

/gcbrun

@phbnf phbnf requested review from roger2hk and removed request for pav-kv July 18, 2022 15:27
@roger2hk roger2hk requested a review from a team as a code owner August 8, 2022 12:25
@roger2hk
Copy link
Contributor

roger2hk commented Aug 8, 2022

/gcbrun

Copy link
Contributor

@roger2hk roger2hk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR. LGTM with some minor comments.

submission/distributor_test.go Show resolved Hide resolved
@roger2hk
Copy link
Contributor

roger2hk commented Aug 9, 2022

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants