Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup log list v1 dependencies #977

Merged
merged 11 commits into from
Sep 10, 2022
Merged

Cleanup log list v1 dependencies #977

merged 11 commits into from
Sep 10, 2022

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented Sep 8, 2022 •
edited
Loading

As it is getting close to the CT log list v1, v2 turndown, the following items are included in this PR.

  • Remove log list v1 package and its dependencies.
  • Migrate loglist dependency from v1 to v3 in ctclient cmd.
  • Migrate loglist dependency from v1 to v3 in ctutil/loginfo.go.
  • Migrate loglist dependency from v1 to v3 in ctutil/sctscan.go.
  • Migrate loglist dependency from v1 to v3 in trillian/integration/ct_hammer/main.go.

Checklist

@roger2hk roger2hk requested a review from a team as a code owner September 8, 2022 09:00
@roger2hk roger2hk requested review from pphaneuf and removed request for a team September 8, 2022 09:00
@roger2hk roger2hk requested review from getagit and phbnf September 8, 2022 14:53
getagit
getagit approved these changes Sep 9, 2022
View reviewed changes
Copy link

@getagit getagit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roger2hk roger2hk merged commit aff1cef into google:master Sep 10, 2022
@roger2hk roger2hk deleted the loglist-dependency-cleanup branch September 10, 2022 14:23
@roger2hk roger2hk mentioned this pull request Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getagit getagit getagit approved these changes

@pphaneuf pphaneuf Awaiting requested review from pphaneuf pphaneuf is a code owner automatically assigned from google/certificate-transparency

@phbnf phbnf Awaiting requested review from phbnf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roger2hk @getagit