Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/ctclient: Fix doubled https in --log_name #990

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

acohn
Copy link
Contributor

@acohn acohn commented Oct 24, 2022

The URL format in Google's v1 and v3 log lists is different - v1 doesn't include the https:// protocol, but v3 does. The fix in aff1cef to use v3 log lists didn't account for this change.

Fixes #989

Checklist

I'm not sure if either of these apply; this is a simple bugfix that should have been done as part of aff1cef. It doesn't need additional documentation imo.

The URL format in v1 and v3 log lists was different - v1 doesn't include the https:// protocol, but v3 does.
@acohn acohn requested a review from a team as a code owner October 24, 2022 17:43
@acohn acohn requested review from getagit and removed request for a team October 24, 2022 17:43
@pphaneuf
Copy link
Contributor

/gcbrun

Copy link
Contributor

@pphaneuf pphaneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add yourself to the CONTRIBUTORS/AUTHORS as appropriate, by the way.

@roger2hk
Copy link
Contributor

/gcbrun

Copy link
Contributor

@pphaneuf pphaneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pphaneuf pphaneuf merged commit 52d9f96 into google:master Oct 25, 2022
@acohn acohn deleted the patch-1 branch October 26, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client/ctclient: Doubled https:// when using --log_name
3 participants