Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export removeCert, add StoreWithDisposition #62

Merged
merged 2 commits into from
May 3, 2023
Merged

Export removeCert, add StoreWithDisposition #62

merged 2 commits into from
May 3, 2023

Conversation

n-canter
Copy link
Contributor

  • Export removeCert() as (WinCertStore).RemoveCertByContext().
  • Add StoreWithDisposition() method, disposition specifies the action to take if a matching certificate or a link to a matching certificate already exists in the store.

ItsMattL
ItsMattL reviewed Apr 24, 2023
View reviewed changes
certtostore_windows.go Outdated Show resolved Hide resolved
@n-canter
Export removeCert, add StoreWithDisposition
98459ec 
* Export removeCert() as (WinCertStore).RemoveCertByContext().
* Add StoreWithDisposition() method, disposition specifies the
  action to take if a matching certificate
  or a link to a matching certificate already exists in the store.
@n-canter
Copy link
Contributor Author

n-canter commented May 2, 2023

Hey @ItsMattL it seems, some internal tests fail. This is either due to WinCertStorage interface change or due to renaming of removeCert method.
I can update this pull request to keep interface untouched and/or to keep removeCert method, if that helps to merge it sooner. Wdyt?

@copybara-service copybara-service bot merged commit ce5ed45 into google:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsMattL ItsMattL ItsMattL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-canter @ItsMattL