Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to iterate over cetificates in store #72

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

harture
Copy link

@harture harture commented May 3, 2024

If there is multiple certificates issued by same Issuer, only the first one is accessible.
This PR provides a way to iterate over certificates and choose the one to interact with.

Copy link

google-cla bot commented May 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@harture harture marked this pull request as draft May 3, 2024 13:52
@harture harture marked this pull request as ready for review May 3, 2024 13:57
@harture harture marked this pull request as draft May 3, 2024 14:07
Copy link
Contributor

@mit-da mit-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 71, the CertWithContext() in the WinCertStorage interface needs to be updated for this change.

@mit-da
Copy link
Contributor

mit-da commented May 20, 2024

Looks like you also have to sign the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants