This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Feature/datetime factory improvement #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he dateTimeFactory.
…Factory, as suggested in the left TODOs.
|
There is a fork of charts at exafree/charts_cf that accepts pull requests. |
Thanks for the information ! Great idea :D |
|
This project is no longer maintained, and cannot accept any PRs. Community members interested in collaborating on a community-maintained fork can coordinate in this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No breaking changes
-Added the missing dateTimeFactory parameter on TimeSeriesChart.createCommonChart method.
It also fixes #490
-Added a Timezone aware DateTimeFactory implementation (related to a TODO left for @cbbraun)
I use this implementation in a prod application with localized Data visualisation, this feature is needed and useful.
@lorrainekan , as you seem to be the most active maintainer on this repo on this repo, could you please take a look ? :) Thanks a lot 🙏
Corentin