GitHub Sync (nullability support sync) #646

cbbraun · 2021-06-25T23:30:57Z

This is an automatically generated pull request.

Finally syncing out after someone internal generously went through and marked everything with null safety.

google-cla · 2021-06-25T23:34:27Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:34:42Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:34:58Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:35:10Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:35:32Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:35:44Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:35:57Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:36:00Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:36:38Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:36:50Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:36:53Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:36:53Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:37:02Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:37:15Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:37:26Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:37:42Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:37:52Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:38:07Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:38:24Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:38:37Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:39:06Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:39:19Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:39:30Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:39:48Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:39:48Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:39:57Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-25T23:40:20Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

PiperOrigin-RevId: 370588847

WANT_LGTM=any *** Reason for rollback *** Breaks multiple Greentea FE widgets, causing presubmit TAP failures. *** Original change description *** Fix build warnings in charts_common *** PiperOrigin-RevId: 370712865

*** Reason for rollback *** Rollforward after fix in greentea submitted in cl/370722339. Global presubmit is showing all targets ok after deflakes *** Original change description *** Automated g4 rollback of changelist 370588847. WANT_LGTM=any *** Reason for rollback *** Breaks multiple Greentea FE widgets, causing presubmit TAP failures. *** Original change description *** Fix build warnings in charts_common *** *** PiperOrigin-RevId: 371141851

PiperOrigin-RevId: 371425261

PiperOrigin-RevId: 371617443

PiperOrigin-RevId: 371908750

PiperOrigin-RevId: 372183756

PiperOrigin-RevId: 372426281

PiperOrigin-RevId: 374314810

PiperOrigin-RevId: 375978148

PiperOrigin-RevId: 375997369

PiperOrigin-RevId: 378428877

PiperOrigin-RevId: 378497037

This deprecated API is scheduled to be removed in flutter/flutter#83924 PiperOrigin-RevId: 378523673

PiperOrigin-RevId: 379206830

PiperOrigin-RevId: 379784071

PiperOrigin-RevId: 379986913

PiperOrigin-RevId: 380237923

PiperOrigin-RevId: 381309874

PiperOrigin-RevId: 381509039

…s to pass PiperOrigin-RevId: 381579690

PiperOrigin-RevId: 382373361

PiperOrigin-RevId: 382380502

google-cla · 2021-06-30T21:20:56Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

These all came from internal Googlers so CLA is not required.

ℹ️ Googlers: Go here for more info.

* upstream/master: GitHub Sync (nullability support sync) (google#646) GitHub Sync (google#605)

google-cla bot added the cla: yes label Jun 25, 2021

google-cla bot added cla: no and removed cla: yes labels Jun 25, 2021

Googler and others added 23 commits June 30, 2021 14:11

Fix build warnings in charts_common

df9a9f6

PiperOrigin-RevId: 370588847

Automated g4 rollback of changelist 370588847.

556da0b

WANT_LGTM=any *** Reason for rollback *** Breaks multiple Greentea FE widgets, causing presubmit TAP failures. *** Original change description *** Fix build warnings in charts_common *** PiperOrigin-RevId: 370712865

Internal changes

368877e

PiperOrigin-RevId: 371425261

Internal changes

d45d55b

PiperOrigin-RevId: 371617443

Internal changes

1fb0f84

PiperOrigin-RevId: 371908750

Internal changes

3e1da50

PiperOrigin-RevId: 372183756

Internal changes

5d43236

PiperOrigin-RevId: 372426281

Internal changes

0b40f17

PiperOrigin-RevId: 374314810

Internal changes

84adf34

PiperOrigin-RevId: 375978148

Internal changes

4f9cdac

PiperOrigin-RevId: 375997369

Internal changes

4cf719b

PiperOrigin-RevId: 378428877

Internal changes

b39f4dc

PiperOrigin-RevId: 378497037

Migrate deprecated TextTheme API from body1 to bodyText2

72eb27d

This deprecated API is scheduled to be removed in flutter/flutter#83924 PiperOrigin-RevId: 378523673

Internal changes

0e3ea3d

PiperOrigin-RevId: 379206830

Internal changes

324bd58

PiperOrigin-RevId: 379784071

Internal changes

2ac6354

PiperOrigin-RevId: 379986913

Fixed nullability issues in chart classes.

c2fab81

PiperOrigin-RevId: 380237923

Migrate //third_party/dart/charts_flutter to null safety.

39ded09

PiperOrigin-RevId: 381309874

Migrate //third_party/dart/charts_flutter/examples to null safety.

5abbb08

PiperOrigin-RevId: 381509039

Bump sdk version for nullability support to hopefully get travis test…

4d2dfcf

…s to pass PiperOrigin-RevId: 381579690

Fix mockito testing for null safety

7319397

PiperOrigin-RevId: 382373361

Fixing tests removing some mockito use

8316522

PiperOrigin-RevId: 382380502

cbbraun added cla: yes and removed cla: no labels Jun 30, 2021

lorrainekan self-requested a review June 30, 2021 21:24

lorrainekan approved these changes Jun 30, 2021

View reviewed changes

cbbraun merged commit 26b73c6 into master Jun 30, 2021

samandmoore added a commit to Betterment/charts that referenced this pull request Jul 1, 2021

Merge remote-tracking branch 'upstream/master' into sam-merge-upstream

8e16bf0

* upstream/master: GitHub Sync (nullability support sync) (google#646) GitHub Sync (google#605)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sync (nullability support sync) #646

GitHub Sync (nullability support sync) #646

cbbraun commented Jun 25, 2021 •

edited

Loading

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 30, 2021 •

edited by cbbraun

Loading

GitHub Sync (nullability support sync) #646

GitHub Sync (nullability support sync) #646

Conversation

cbbraun commented Jun 25, 2021 • edited Loading

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 25, 2021

google-cla bot commented Jun 30, 2021 • edited by cbbraun Loading

cbbraun commented Jun 25, 2021 •

edited

Loading

google-cla bot commented Jun 30, 2021 •

edited by cbbraun

Loading